Skip to content

Allow writeToDisk as a middleware option #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
tech4him1 opened this issue Mar 30, 2018 · 4 comments · Fixed by #1520
Closed
1 of 2 tasks

Allow writeToDisk as a middleware option #1357

tech4him1 opened this issue Mar 30, 2018 · 4 comments · Fixed by #1520

Comments

@tech4him1
Copy link

tech4him1 commented Mar 30, 2018

  • Operating System: Win10
  • Node Version: 9.2.0
  • NPM Version: Yarn 1.5.1
  • webpack Version: 4.4.1
  • webpack-dev-server Version: 3.1.1
  • This is a bug
  • This is a modification request

For Features; What is the motivation and/or use-case for the feature?

writeToDisk was added to webpack-dev-middleware as an option. Can it be passed through so that the option can be set directly on the dev server?

Assuming the option can just be passed through, it should be a very simple change:

this.middleware = webpackDevMiddleware(compiler, Object.assign({}, options, wdmOptions));

cc/ @shellscape

@tech4him1 tech4him1 changed the title Allow writeToDisk to pass through Allow writeToDisk as a middleware option Mar 30, 2018
@Viijay-Kr
Copy link

Viijay-Kr commented Apr 27, 2018

I am facing the same issue as well.I was wondering when WDM supports this option why wont WDS support it ? and I end up here . I Would be pleased to see this simple thing shipped in the next release. As mentioned in 'Readme' I believe no features will be accepted until the maintenance work is complete

@alexander-akait
Copy link
Member

@VijayKrish93 because webpack-dev-server in maintenance mode (https://github.com/webpack/webpack-dev-server#project-in-maintenance) and only bug/security fixes accepted. My recommendation is migration on webpack-serve. Thanks!

@Binarytales
Copy link

Given that this project is no longer in maintenance mode (6c1d8d8#diff-04c6e90faac2675aa89e2176d2eec7d8) could this issue be reopened as this functionallity would be very handy for me right now.

@alexander-akait
Copy link
Member

alexander-akait commented Aug 31, 2018

@Binarytales feel free to send a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants