Skip to content

Issue with Chrome Popup Blocker Pro extension and webpack dev mode #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jneveux opened this issue Apr 18, 2016 · 1 comment
Closed

Issue with Chrome Popup Blocker Pro extension and webpack dev mode #457

jneveux opened this issue Apr 18, 2016 · 1 comment

Comments

@jneveux
Copy link

jneveux commented Apr 18, 2016

Hi,

I encountered a problem with Chrome extension http://popup-blocker.org/ which is injecting a script tag at the end of the index page.

The script webpack-dev-server/client/index.js is looking for the last script tag:
var scriptElements = document.getElementsByTagName("script"); var scriptHost = scriptElements[scriptElements.length-1].getAttribute("src").replace(/\/[^\/]+$/, "");

Original issue PatrickJS/PatrickJS-starter#511 took me a few hours to detect.)

It would be nice, if the webpack script tag selection could rely on something other than being the last one.

Thanks,

Jean

@SpaceK33z
Copy link
Member

This is kind of a dupe of #117. We're discussing ways to improve the current script detection over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants