Skip to content

Inline mode shouldn't add a second WDS client to entry #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alecmev opened this issue May 21, 2017 · 1 comment
Closed

Inline mode shouldn't add a second WDS client to entry #913

alecmev opened this issue May 21, 2017 · 1 comment

Comments

@alecmev
Copy link

alecmev commented May 21, 2017

This is related to #711. If there is webpack-dev-server/client in the entry of a Webpack config, then WDS should just skip adding it and/or display a warning. The same should probably be done for hot/hotOnly. Sometimes, like when using React Hot Loader, you (at the same time) want to:

  1. Use webpack-dev-server CLI
  2. Have inline mode enabled (so that it displays a proper "Project is running at")
  3. Have an entry with webpack-dev-server/client defined in it explicitly

Edit: Just found #616. My proposed solution is different, but the problem is the same, so, it probably makes sense to merge them. Let me know what's preferred.

@shellscape
Copy link
Contributor

I think it makes sense to continue the discussion on #616. Closing this one for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants