fix: detect namespace imports used as default values in destructuring (#1386)

Author: jstaab

packages/knip/fixtures/imports-namespace/index.ts

@@ -11,6 +11,7 @@ import * as NS6_OPAQUE from './namespace6-opaque';
 import * as NS7 from './namespace7';
 import * as NS8 from './namespace8';
 import * as NS9 from './namespace9';
+import * as NS10 from './namespace10';
 import fn from 'external';
 
 NS.identifier15;
@@ -47,3 +48,7 @@ const func = () => {
   const cond = fn() ? NS9 : { identifier43: 43 };
   cond.identifier43;
 };
+
+const props: { values?: { identifier45: number; identifier46: number } } = {};
+const { values = NS10 } = props;
+values.identifier45

packages/knip/fixtures/imports-namespace/namespace10.ts

@@ -0,0 +1,2 @@
+export const identifier45 = 45;
+export const identifier46 = 46;

packages/knip/src/typescript/ast-helpers.ts

@@ -243,6 +243,7 @@ export const isConsiderReferencedNS = (node: ts.Identifier) =>
   ts.isSpreadAssignment(node.parent) ||
   ts.isArrayLiteralExpression(node.parent) ||
   ts.isExportAssignment(node.parent) ||
+  (ts.isBindingElement(node.parent) && node.parent.initializer === node) ||
   ts.isTypeQueryNode(node.parent.parent);
 
 export const isInOpaqueExpression = (node: ts.Node): boolean =>

packages/knip/test/imports-namespace.test.ts

@@ -15,12 +15,13 @@ test('Ignore namespace re-export by entry file', async () => {
   assert(issues.exports['namespace5.ts']['NS5.identifier36']);
   assert(issues.exports['namespace6.ts']['NS6.identifier38']);
   assert(issues.exports['namespace9.ts']['NS9.identifier44']);
+  assert(!issues.exports['namespace10.ts'], 'NS10');
 
   assert.deepEqual(counters, {
     ...baseCounters,
     unlisted: 1,
     exports: 4,
-    processed: 14,
-    total: 14,
+    processed: 15,
+    total: 15,
   });
 });