Handle package.json exports for outDir="." (resolve #1738)

Author: webpro

packages/knip/fixtures/package-entry-points-root-dir/entry.ts

@@ -0,0 +1 @@
+export const a = 'a';

packages/knip/fixtures/package-entry-points-root-dir/package.json

@@ -0,0 +1,7 @@
+{
+  "name": "@fixtures/package-entry-points-root-dir",
+  "exports": {
+    "./entry": "./dist/entry.js",
+    "./types": { "types": "./dist/types.d.ts" }
+  }
+}

packages/knip/fixtures/package-entry-points-root-dir/tsconfig.json

@@ -0,0 +1,6 @@
+{
+  "compilerOptions": {
+    "outDir": "dist",
+    "rootDir": "./"
+  }
+}

packages/knip/fixtures/package-entry-points-root-dir/types.ts

@@ -0,0 +1 @@
+export type A = 'a';

packages/knip/src/util/to-source-path.ts

@@ -33,11 +33,9 @@ export const augmentWorkspace = (
 
 const isUnderOutDir = (absPath: string, outDir: string) => absPath === outDir || absPath.startsWith(`${outDir}/`);
 
-const isUnderSrcDir = (absPath: string, srcDir: string) => absPath === srcDir || absPath.startsWith(`${srcDir}/`);
-
 const rewritePattern = (sourceMaps: SourceMap[], absSpecifier: string, extensions: string) => {
   for (const { srcDir, outDir } of sourceMaps) {
-    if (!isUnderSrcDir(absSpecifier, srcDir) && isUnderOutDir(absSpecifier, outDir)) {
+    if (srcDir !== outDir && isUnderOutDir(absSpecifier, outDir)) {
       return srcDir + absSpecifier.slice(outDir.length).replace(matchExt, extensions);
     }
   }
@@ -93,7 +91,7 @@ export const toSourceMappedSpecifiers = (
   const out: string[] = [];
   if (!ws?.sourceMaps) return out;
   for (const { srcDir, outDir } of ws.sourceMaps) {
-    if (!isUnderSrcDir(absSpecifier, srcDir) && isUnderOutDir(absSpecifier, outDir)) {
+    if (srcDir !== outDir && isUnderOutDir(absSpecifier, outDir)) {
       out.push(srcDir + absSpecifier.slice(outDir.length).replace(matchExt, extensions));
     }
   }

packages/knip/test/package-entry-points-root-dir.test.ts

@@ -0,0 +1,22 @@
+import assert from 'node:assert/strict';
+import test from 'node:test';
+import { main } from '../src/index.ts';
+import baseCounters from './helpers/baseCounters.ts';
+import { createOptions } from './helpers/create-options.ts';
+import { resolve } from './helpers/resolve.ts';
+
+const cwd = resolve('fixtures/package-entry-points-root-dir');
+
+test('Resolve package entry points with tsconfig rootDir: "."', async () => {
+  const options = await createOptions({ cwd });
+  const { counters, issues, configurationHints } = await main(options);
+
+  assert.deepEqual(issues.files, {});
+  assert.deepEqual(configurationHints, []);
+
+  assert.deepEqual(counters, {
+    ...baseCounters,
+    processed: 2,
+    total: 2,
+  });
+});

packages/knip/test/subpath-imports-outdir.test.ts

@@ -9,11 +9,14 @@ const cwd = resolve('fixtures/subpath-imports-outdir');
 
 test('Resolve subpath imports to outDir with rootDir="."', async () => {
   const options = await createOptions({ cwd });
-  const { counters } = await main(options);
+  const { counters, configurationHints } = await main(options);
+
+  assert.equal(configurationHints.length, 1);
+  assert.equal(configurationHints[0].type, 'entry-redundant');
 
   assert.deepEqual(counters, {
     ...baseCounters,
-    processed: 5,
-    total: 5,
+    processed: 3,
+    total: 3,
   });
 });