M92 (#14)

* Add support for m92.

* fix: Stupid bug for add icecandidate.

* fix bug.

Author: cloudwebrtc

include/base/portable.h

@@ -82,7 +82,7 @@ class string {
   }
 
   inline std::string std_string() const {
-    return std::string(m_dynamic == 0 ? m_buf : m_dynamic);
+    return std::string(m_dynamic == 0 ? m_buf : m_dynamic, m_length);
   }
 };
 

src/rtc_peerconnection_impl.cc

@@ -292,11 +292,11 @@ void RTCPeerConnectionImpl::OnSignalingChange(
 
 void RTCPeerConnectionImpl::AddCandidate(const string mid,
                                          int mid_mline_index,
-                                         const string candiate) {
+                                         const string cand_sdp) {
   webrtc::SdpParseError error;
   webrtc::IceCandidateInterface* candidate = webrtc::CreateIceCandidate(
-      to_std_string(mid), mid_mline_index, to_std_string(candiate), &error);
-  if (!candidate)
+      to_std_string(mid), mid_mline_index, to_std_string(cand_sdp), &error);
+  if (candidate != nullptr)
     rtc_peerconnection_->AddIceCandidate(candidate);
 }
 

src/rtc_rtp_parameters_impl.cc

@@ -134,17 +134,15 @@ webrtc::RtpParameters RTCRtpParametersImpl::rtp_parameters() {
 }
 
 const string RTCRtpParametersImpl::transaction_id() {
-  auto temp = rtp_parameters_.transaction_id;
-  return temp;
+  return rtp_parameters_.transaction_id;
 }
 
 void RTCRtpParametersImpl::set_transaction_id(const string id) {
   rtp_parameters_.transaction_id = to_std_string(id);
 }
 
 const string RTCRtpParametersImpl::mid() {
-  auto temp = rtp_parameters_.mid;
-  return temp;
+  return rtp_parameters_.mid;
 }
 void RTCRtpParametersImpl::set_mid(const string mid) {
   rtp_parameters_.mid = to_std_string(mid);
@@ -308,8 +306,7 @@ webrtc::RtpExtension RTCRtpExtensionImpl::rtp_extension() {
 }
 
 const string RTCRtpExtensionImpl::ToString() const {
-  auto temp = rtp_extension_.ToString();
-  return temp;
+  return rtp_extension_.ToString();
 }
 
 RTCRtpCodecParametersImpl::RTCRtpCodecParametersImpl(