Fix crash when the Upgrade header cannot be read#2231
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible that the Upgrade header is correctly received and handled
(the
'upgrade'event is emitted) without its value being returned tothe user. This can happen if the number of received headers exceed the
server.maxHeadersCountorrequest.maxHeadersCountthreshold. In thiscase
incomingMessage.headers.upgrademay not be set.Handle the case correctly and abort the handshake.
Fixes #2230