feat: add support for SMPlayer#154
Merged
alxhotel merged 3 commits intowebtorrent:masterfrom Jun 8, 2021
Merged
Conversation
|
🙌 Thanks for opening this pull request! You're awesome. |
Add support for SMPlayer with --smplayer . SMPlayer is quite popular player which is user-friendly wrapper for MPV and MPlayer.
alxhotel
approved these changes
Jun 5, 2021
Member
|
I have made two small changes:
|
DiegoRBaquero
approved these changes
Jun 8, 2021
Member
DiegoRBaquero
left a comment
DiegoRBaquero
left a comment
There was a problem hiding this comment.
@alxhotel you can go ahead and merge
|
🎉 Congrats on getting your first pull request landed! |
DiegoRBaquero
pushed a commit
that referenced
this pull request
Jun 8, 2021
# [3.3.0](v3.2.4...v3.3.0) (2021-06-08) ### Features * add support for SMPlayer ([#154](#154)) ([875d035](875d035))
Member
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[X] New feature
[ ] Other, please explain:
Add support for SMPlayer with --smplayer . SMPlayer is quite popular player which is user-friendly wrapper for MPV and MPlayer. SMPlayer is installed by default in a lot of Linux distributions, so I expect this to be a useful for many users. Also, there is a Windows port and probably the code will work with Windows or will require slight modification.