Fix: Chromecast logic & typo#175
Merged
DiegoRBaquero merged 2 commits intowebtorrent:masterfrom Jul 14, 2021
Merged
Conversation
DiegoRBaquero
approved these changes
Jul 14, 2021
webtorrent-bot
pushed a commit
that referenced
this pull request
Jul 14, 2021
## [3.3.2](v3.3.1...v3.3.2) (2021-07-14) ### Bug Fixes * Chromecast logic & typo ([#175](#175)) ([8234278](8234278))
|
🎉 This PR is included in version 3.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Changed
if (argv.chromecast !== false) {toif (argv.chromecast) {, so the chromecast logic doesn't execute.(I don't have chromecast, so that's why I probably didn't have any issues, but this should fix it)
Which issue (if any) does this pull request address?
Is there anything you'd like reviewers to focus on?
Nope.