Add peerflix-style interactive select mode#234
Merged
DiegoRBaquero merged 5 commits intowebtorrent:masterfrom Jun 2, 2022
Merged
Add peerflix-style interactive select mode#234DiegoRBaquero merged 5 commits intowebtorrent:masterfrom
DiegoRBaquero merged 5 commits intowebtorrent:masterfrom
Conversation
|
🙌 Thanks for opening this pull request! You're awesome. |
Contributor
Author
|
Ping! |
Member
|
Can you add a video/gif of it working? Also, are there any scenarios were the await might throw an error? if that's the case, would be great to handle it |
Contributor
Author
|
Here's a gif of it in action:
|
Contributor
Author
|
Per inquisitor's README.md, it can indeed throw errors if the terminal isn't capable of rendering the menu for some reason. The above commit should handle this case (and anything else that might result in an error). |
DiegoRBaquero
approved these changes
Jun 2, 2022
|
🎉 Congrats on getting your first pull request landed! |
webtorrent-bot
pushed a commit
that referenced
this pull request
Jun 2, 2022
# [4.1.0](v4.0.4...v4.1.0) (2022-06-02) ### Features * add peerflix-style interactive select mode ([#234](#234)) ([4540a0a](4540a0a))
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[X] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Added a peerflix-style interactive select mode.
Which issue (if any) does this pull request address?
#130
Is there anything you'd like reviewers to focus on?
Hopefully I got the formatting right!