Merged
Conversation
… reserved and downloaded.
ThaUnknown
changed the title
webtorrent-bot
pushed a commit
that referenced
this pull request
Jun 2, 2024
## [5.0.1](v5.0.0...v5.0.1) (2024-06-02) ### Bug Fixes * -s / --select not working ([#304](#304)) ([825b0ee](825b0ee))
|
🎉 This PR is included in version 5.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
This PR fixes where
-s/--selectdoes not work as expected, leading to all files being downloaded, rather than the selected. This is done by moving where thetorrent.sois defined, as this must occur before metadata to ensure reservations aren't made.Note: This PR does not address the issue that if a piece contains more than just the selected file, it will still be created. e.g. in the Sintel torrent
--select 0will include the first 5 subtitles and the first 121KB of the .mp4 due to the first piece containing all of this data.Which issue (if any) does this pull request address?
-fixes: #222
Is there anything you'd like reviewers to focus on?