Skip to content

Commit 30d1b56

Browse files
committed
make legend detection code more robust. fixes tidyverse#3963
1 parent d3d47be commit 30d1b56

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

R/layer-sf.R

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,16 @@ LayerSf <- ggproto("LayerSf", Layer,
4848

4949
# automatically determine the legend type
5050
if (is.null(self$legend_key_type)) {
51+
# first, set default value in case downstream tests fail
52+
self$geom_params$legend <- "polygon"
53+
54+
# now check if the type is not polygon
5155
if (is_sf(data)) {
5256
sf_type <- detect_sf_type(data)
5357
if (sf_type == "point") {
5458
self$geom_params$legend <- "point"
5559
} else if (sf_type == "line") {
5660
self$geom_params$legend <- "line"
57-
} else {
58-
self$geom_params$legend <- "polygon"
5961
}
6062
}
6163
} else {

0 commit comments

Comments
 (0)