Skip to content

Commit 159a5d6

Browse files
committed
~ Internal refactor to fix lint issues
1 parent e88c14c commit 159a5d6

File tree

3 files changed

+27
-13
lines changed

3 files changed

+27
-13
lines changed

src/react.test.tsx

Lines changed: 20 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { afterEach, beforeEach, expect, expectTypeOf, test, vi } from 'vitest'
77
import { TwoAndEight } from './2n8.js'
88
import { createReactStore } from './react.js'
99

10-
const RenderCount: FC<{ title: string }> = ({ title }) => {
10+
const RenderCount: FC<{ readonly title: string }> = ({ title }) => {
1111
const renderCount = useRef(0)
1212

1313
renderCount.current = renderCount.current + 1
@@ -363,17 +363,25 @@ test('should handle complex state', async () => {
363363
const addToArr = useStore((s) => s.addToArr)
364364
return (
365365
<div>
366-
{data.foo && <div>Foo: {data.foo}</div>}
366+
{data.foo ? <div>Foo: {data.foo}</div> : null}
367367
<div>Bar: {data.bar}</div>
368368
<div>
369369
{arr.map((a) => (
370370
<div key={a}>{a}</div>
371371
))}
372372
</div>
373-
<button onClick={changeData}>Change Data</button>
374-
<button onClick={changeDataDeep}>Change Data Deep</button>
375-
<button onClick={deleteData}>Delete Data</button>
376-
<button onClick={addToArr}>Add To Array</button>
373+
<button onClick={changeData} type="button">
374+
Change Data
375+
</button>
376+
<button onClick={changeDataDeep} type="button">
377+
Change Data Deep
378+
</button>
379+
<button onClick={deleteData} type="button">
380+
Delete Data
381+
</button>
382+
<button onClick={addToArr} type="button">
383+
Add To Array
384+
</button>
377385
</div>
378386
)
379387
}
@@ -433,8 +441,12 @@ test('should handle complex derived state', async () => {
433441
const reset = useStore((s) => s.reset)
434442
return (
435443
<div>
436-
<button onClick={add}>Add</button>
437-
<button onClick={reset}>Reset</button>
444+
<button onClick={add} type="button">
445+
Add
446+
</button>
447+
<button onClick={reset} type="button">
448+
Reset
449+
</button>
438450
<div data-testid="derived">{derivedState.foo ? 'yes' : 'no'}</div>
439451
<div>{JSON.stringify(emptyObj)}</div>
440452
</div>

src/react.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export function createReactStore<Store extends TwoAndEight>(
2020

2121
let cache = {} as State<Store>
2222

23-
function hook<Field>(
23+
function useStore<Field>(
2424
selector: (state: Omit<Store, '$reset' | '$commit'>) => Field,
2525
): Field {
2626
return useSyncExternalStore(
@@ -45,9 +45,9 @@ export function createReactStore<Store extends TwoAndEight>(
4545
)
4646
}
4747

48-
hook.subscribe = store.subscribe
49-
hook.getInitialState = store.getInitialState
50-
hook.getState = store.getState
48+
useStore.subscribe = store.subscribe
49+
useStore.getInitialState = store.getInitialState
50+
useStore.getState = store.getState
5151

52-
return hook
52+
return useStore
5353
}

website/content/counter.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ const Counter: FC = () => {
6363
paddingLeft: '1rem',
6464
paddingRight: '1rem',
6565
}}
66+
type="button"
6667
>
6768
+ 1
6869
</button>
@@ -73,6 +74,7 @@ const Counter: FC = () => {
7374
paddingLeft: '1rem',
7475
paddingRight: '1rem',
7576
}}
77+
type="button"
7678
>
7779
Reset
7880
</button>

0 commit comments

Comments
 (0)