fix(routing): update routePattern when using sequence (#14132)

Author: ematipico

.changeset/dull-poems-obey.md

@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Fixes a bug where the property `Astro.routePattern`/`context.routePattern` wasn't updated when using a rewrite via middleware.

packages/astro/src/core/middleware/sequence.ts

@@ -80,6 +80,7 @@ export function sequence(...handlers: MiddlewareHandler[]): MiddlewareHandler {
 						handleContext.url = new URL(newRequest.url);
 						handleContext.cookies = new AstroCookies(newRequest);
 						handleContext.params = getParams(routeData, pathname);
+						handleContext.routePattern = routeData.route;
 						setOriginPathname(
 							handleContext.request,
 							oldPathname,

packages/astro/test/fixtures/rewrite-route-pattern/astro.config.mjs

@@ -0,0 +1,4 @@
+import { defineConfig } from 'astro/config';
+
+// https://astro.build/config
+export default defineConfig({});

packages/astro/test/fixtures/rewrite-route-pattern/package.json

@@ -0,0 +1,8 @@
+{
+  "name": "@test/rewrite-route-pattern",
+  "version": "0.0.0",
+  "private": true,
+  "dependencies": {
+    "astro": "workspace:*"
+  }
+}

packages/astro/test/fixtures/rewrite-route-pattern/src/middleware.js

@@ -0,0 +1,17 @@
+import { defineMiddleware, sequence } from 'astro:middleware';
+
+export const first = defineMiddleware(async (context, next)=> {
+	if (context.url.pathname === '/index2') {
+		return next('/123/post')
+	} else {
+		
+		return next(`/destination`);
+	}
+});
+
+export const second = defineMiddleware(async (context, next)=> {
+	context.locals.pattern = context.routePattern;
+	return next();
+});
+
+export const onRequest = sequence(first, second);

packages/astro/test/fixtures/rewrite-route-pattern/src/pages/[id]/post.astro

@@ -0,0 +1,5 @@
+---
+const pattern = Astro.locals.pattern;
+---
+
+<p>{pattern}</p>

packages/astro/test/fixtures/rewrite-route-pattern/src/pages/destination.astro

@@ -0,0 +1,5 @@
+---
+const pattern = Astro.locals.pattern;
+---
+
+<p>{pattern}</p>

packages/astro/test/fixtures/rewrite-route-pattern/src/pages/index.astro

@@ -730,7 +730,7 @@ describe('Runtime error in SSR, custom 500', () => {
 	});
 });
 
-describe('Issue 13633', async () => {
+describe('Rewrite issue 13633', async () => {
 	/** @type {import('./test-utils').Fixture} */
 	let fixture;
 	let devServer;
@@ -754,3 +754,33 @@ describe('Issue 13633', async () => {
 		assert.equal($('h1').text(), 'Index page');
 	});
 });
+
+describe('Rewrite', async () => {
+	/** @type {import('./test-utils').Fixture} */
+	let fixture;
+	let devServer;
+	before(async () => {
+		fixture = await loadFixture({
+			root: './fixtures/rewrite-route-pattern/',
+			output: 'server',
+			adapter: testAdapter(),
+		});
+		devServer = await fixture.startDevServer();
+	});
+
+	after(async () => {
+		await devServer.stop();
+	});
+
+	it('should correctly update routePattern with using sequence in middleware', async () => {
+		let html = await fixture.fetch('/').then((res) => res.text());
+		let $ = cheerioLoad(html);
+
+		assert.equal($('p').text(), '/destination');
+
+		html = await fixture.fetch('/index2').then((res) => res.text());
+		$ = cheerioLoad(html);
+
+		assert.equal($('p').text(), '/[id]/post');
+	});
+});