Merge pull request #385 from x-motemen/revert-378-rel_ssh

Revert "feat: enable relative path ssh URL"

Author: Songmu

url.go

@@ -112,16 +112,12 @@ func newURL(ref string, ssh, forceMe bool) (*url.URL, error) {
 			user := matched[1]
 			host := matched[2]
 			path := matched[3]
-			// When two conditions below are satisfied:
-			// 1. the path is a relative path, which not beginning with a slash, like `path/to/repo`.
-			// 2. the host is not github.com, which doesn't support relative paths.
-			// then we convert the given SCP style URL to a normal style and relative path URL using tilde, like `ssh://[email protected]/~/path/to/repo`.
-			if strings.HasPrefix(path, "/") {
-				path = strings.TrimPrefix(path, "/")
-			} else if host != "github.com" {
-				path = "~/" + path
-			}
-			ref = fmt.Sprintf("ssh://%s%s/%s", user, host, path)
+			// If the path is a relative path not beginning with a slash like
+			// `path/to/repo`, we might convert to like
+			// `ssh://[email protected]/~/path/to/repo` using tilde, but
+			// since GitHub doesn't support it, we treat relative and absolute
+			// paths the same way.
+			ref = fmt.Sprintf("ssh://%s%s/%s", user, host, strings.TrimPrefix(path, "/"))
 		} else {
 			// If ref is like "github.com/motemen/ghq" convert to "https://github.com/motemen/ghq"
 			paths := strings.Split(ref, "/")

url_test.go

@@ -20,35 +20,20 @@ func TestNewURL(t *testing.T) {
 		expect: "https://github.com/motemen/pusheen-explorer",
 		host:   "github.com",
 	}, {
-		name:   "scp to github", // Convert SCP-like URL to SSH URL
+		name:   "scp", // Convert SCP-like URL to SSH URL
 		url:    "[email protected]:motemen/pusheen-explorer.git",
 		expect: "ssh://[email protected]/motemen/pusheen-explorer.git",
 		host:   "github.com",
 	}, {
-		name:   "scp with root to github",
+		name:   "scp with root",
 		url:    "[email protected]:/motemen/pusheen-explorer.git",
 		expect: "ssh://[email protected]/motemen/pusheen-explorer.git",
 		host:   "github.com",
 	}, {
-		name:   "scp without user to github",
+		name:   "scp without user",
 		url:    "github.com:motemen/pusheen-explorer.git",
 		expect: "ssh://github.com/motemen/pusheen-explorer.git",
 		host:   "github.com",
-	}, {
-		name:   "scp to others",
-		url:    "[email protected]:repo/www.git",
-		expect: "ssh://[email protected]/~/repo/www.git",
-		host:   "example.com",
-	}, {
-		name:   "scp with root to others",
-		url:    "[email protected]:/repo/www.git",
-		expect: "ssh://[email protected]/repo/www.git",
-		host:   "example.com",
-	}, {
-		name:   "scp without user to others",
-		url:    "example.com:repo/www.git",
-		expect: "ssh://example.com/~/repo/www.git",
-		host:   "example.com",
 	}, {
 		name:   "different name repository",
 		url:    "motemen/ghq",