Skip to content

Commit 4319df0

Browse files
authored
Merge pull request #3719 from LuckyGeck/addregex
Expose urlRegex in the public .d.ts file.
2 parents 89af5b1 + bd3bd7f commit 4319df0

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

addons/xterm-addon-web-links/src/WebLinkProvider.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,10 @@
55

66
import { ILinkProvider, ILink, Terminal, IViewportRange } from 'xterm';
77

8-
interface ILinkProviderOptions {
8+
export interface ILinkProviderOptions {
99
hover?(event: MouseEvent, text: string, location: IViewportRange): void;
1010
leave?(event: MouseEvent, text: string): void;
11+
urlRegex?: RegExp;
1112
}
1213

1314
export class WebLinkProvider implements ILinkProvider {

addons/xterm-addon-web-links/src/WebLinksAddon.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
* @license MIT
44
*/
55

6-
import { Terminal, ILinkMatcherOptions, ITerminalAddon, IDisposable, IViewportRange } from 'xterm';
7-
import { WebLinkProvider } from './WebLinkProvider';
6+
import { Terminal, ILinkMatcherOptions, ITerminalAddon, IDisposable } from 'xterm';
7+
import { ILinkProviderOptions, WebLinkProvider } from './WebLinkProvider';
88

99
const protocolClause = '(https?:\\/\\/)';
1010
const domainCharacterSet = '[\\da-z\\.-]+';
@@ -40,12 +40,6 @@ function handleLink(event: MouseEvent, uri: string): void {
4040
}
4141
}
4242

43-
interface ILinkProviderOptions {
44-
hover?(event: MouseEvent, text: string, location: IViewportRange): void;
45-
leave?(event: MouseEvent, text: string): void;
46-
urlRegex?: RegExp;
47-
}
48-
4943
export class WebLinksAddon implements ITerminalAddon {
5044
private _linkMatcherId: number | undefined;
5145
private _terminal: Terminal | undefined;

addons/xterm-addon-web-links/typings/xterm-addon-web-links.d.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,5 +49,10 @@ declare module 'xterm-addon-web-links' {
4949
* happen even when tooltipCallback hasn't fired for the link yet.
5050
*/
5151
leave?(event: MouseEvent, text: string): void;
52+
53+
/**
54+
* A callback to use instead of the default one.
55+
*/
56+
urlRegex?: RegExp;
5257
}
5358
}

0 commit comments

Comments
 (0)