Merge pull request #4681 from PerBothner/dom-selection

Tyriar · web-flow · commit 9d7b9293eb7a · 2023-08-17T09:01:12.000-07:00
Fix bug in selection handling in dom renderer
diff --git a/src/browser/renderer/dom/DomRendererRowFactory.ts b/src/browser/renderer/dom/DomRendererRowFactory.ts
@@ -166,11 +166,11 @@ export class DomRendererRowFactory {
           cellAmount
           && (
             (isInSelection && oldIsInSelection)
-            || (!isInSelection && cell.bg === oldBg)
+            || (!isInSelection && !oldIsInSelection && cell.bg === oldBg)
           )
           && (
             (isInSelection && oldIsInSelection && colors.selectionForeground)
-            || (!(isInSelection && oldIsInSelection && colors.selectionForeground) && cell.fg === oldFg)
+            || cell.fg === oldFg
           )
           && cell.extended.ext === oldExt
           && isLinkHover === oldLinkHover

Original file line number	Diff line number	Diff line change
`@@ -166,11 +166,11 @@ export class DomRendererRowFactory {`
`166`	`166`	`cellAmount`
`167`	`167`	`&& (`
`168`	`168`	`(isInSelection && oldIsInSelection)`
`169`		`- \|\| (!isInSelection && cell.bg === oldBg)`
	`169`	`+ \|\| (!isInSelection && !oldIsInSelection && cell.bg === oldBg)`
`170`	`170`	`)`
`171`	`171`	`&& (`
`172`	`172`	`(isInSelection && oldIsInSelection && colors.selectionForeground)`
`173`		`- \|\| (!(isInSelection && oldIsInSelection && colors.selectionForeground) && cell.fg === oldFg)`
	`173`	`+ \|\| cell.fg === oldFg`
`174`	`174`	`)`
`175`	`175`	`&& cell.extended.ext === oldExt`
`176`	`176`	`&& isLinkHover === oldLinkHover`