Skip to content

Commit a32776e

Browse files
committed
Move role=document to xterm element
Feedback in microsoft/vscode#98918 said this could improve the UX on screen readers
1 parent 4e18a78 commit a32776e

2 files changed

Lines changed: 1 addition & 1 deletion

File tree

src/browser/AccessibilityManager.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ export class AccessibilityManager extends Disposable {
5757

5858
this._rowContainer = document.createElement('div');
5959
this._rowContainer.classList.add('xterm-accessibility-tree');
60-
this._rowContainer.setAttribute('role', 'document');
6160
this._rowElements = [];
6261
for (let i = 0; i < this._terminal.rows; i++) {
6362
this._rowElements[i] = this._createAccessibilityTreeNode();

src/browser/Terminal.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -383,6 +383,7 @@ export class Terminal extends CoreTerminal implements ITerminal {
383383
this.element.classList.add('terminal');
384384
this.element.classList.add('xterm');
385385
this.element.setAttribute('tabindex', '0');
386+
this.element.setAttribute('role', 'document');
386387
parent.appendChild(this.element);
387388

388389
// Performance: Use a document fragment to build the terminal

0 commit comments

Comments
 (0)