Clipboard

[Dual-Ice]

I'm using the following class to manage the terminal:

import {Terminal} from '@xterm/xterm';
import {Readline} from 'xterm-readline';
import {FitAddon} from '@xterm/addon-fit';

export default class RTerminalService {
    private _readlineAddon: Readline;
    private _terminal: Terminal;
    private _fitAddon: FitAddon;

    public init() {
        this._terminal = new Terminal({ });
        this._fitAddon = new FitAddon();
        this._readlineAddon = new Readline();
        this._terminal.loadAddon(this._fitAddon);
        this._terminal.loadAddon(this._readlineAddon);

        this._fitAddon.fit();

        this._readlineAddon.setCheckHandler(text => {
            const trimmedText = text.trimEnd();
            return !trimmedText.endsWith('&&');
        });

        this._terminal.attachCustomKeyEventHandler(event => {
            if (event.ctrlKey && (event.key === 'c' || event.key === 'v')) {
                return false;
            }

            return true;
        });
    }

    public write(text) {
        this._readlineAddon.write(text);
    }

    public read(text) {
        return this._readlineAddon.read(text);
    }

    public openTerminal(terminalContainer: HTMLDivElement) {
        this._terminal.open(terminalContainer);
    }
}

As you can see, to make copy/paste work, I had to use attachCustomKeyEventHandler.

Do I understand correctly that using @xterm/addon-clipboard won't change anything in my code, and I'll still need to use this hack? Is this addon only necessary for performing some transformations on data going to/from the buffer?

[Dual-Ice]

Why not add this functionality out of the box?

[jerch]

Why not add this functionality out of the box?

Because Ctrl-C is typically used by process management to interrupt the foreground process in unixoid shells, not for copy.

And the clipboard addon is about OSC52 support to allow terminal apps direct clipboard access with a special terminal sequence. So this is a different use case where the app wants to write or read from the clipboard. It has nothing do to with the user clipboard actions.