We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
1 parent a4dbef4 commit 41a20e0Copy full SHA for 41a20e0
.github/workflows/linters.yml
@@ -70,8 +70,12 @@ jobs:
70
- name: Format C/C++ files
71
run: |
72
make format-cpp-build
73
+ # The `make format-cpp` error code is intentionally ignored here
74
+ # because it is irrelevant. We already check if the formatter produced
75
+ # a diff in the next line.
76
+ # Refs: https://github.com/nodejs/node/pull/42764
77
CLANG_FORMAT_START="$(git merge-base HEAD refs/remotes/origin/$GITHUB_BASE_REF)" \
- make format-cpp
78
+ make format-cpp || true
79
git --no-pager diff --exit-code && EXIT_CODE="$?" || EXIT_CODE="$?"
80
if [ "$EXIT_CODE" != "0" ]
81
then
0 commit comments