Skip to content

Commit 48ee4aa

Browse files
committed
refactor(core): 替换IP工具类实现
- 将IpUtil和NetUtil迁移至deprecated包并注释掉原始代码 - 引入新的IPTool工具类替代原有功能 - 更新JobTrigger中的IP获取逻辑 - 修改XxlJobExecutor中的IP和端口处理方式 - 使用StringTool替代原有的字符串判断逻辑
1 parent 84aae28 commit 48ee4aa

File tree

6 files changed

+285
-284
lines changed

6 files changed

+285
-284
lines changed

xxl-job-admin/src/main/java/com/xxl/job/admin/scheduler/trigger/JobTrigger.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@
1313
import com.xxl.job.core.biz.model.ReturnT;
1414
import com.xxl.job.core.biz.model.TriggerParam;
1515
import com.xxl.job.core.enums.ExecutorBlockStrategyEnum;
16-
import com.xxl.job.core.util.IpUtil;
1716
import com.xxl.tool.core.StringTool;
1817
import com.xxl.tool.exception.ThrowableTool;
18+
import com.xxl.tool.http.IPTool;
1919
import jakarta.annotation.Resource;
2020
import org.slf4j.Logger;
2121
import org.slf4j.LoggerFactory;
@@ -192,7 +192,7 @@ private void processTrigger(XxlJobGroup group,
192192
// 5、collection trigger info
193193
StringBuilder triggerMsgSb = new StringBuilder();
194194
triggerMsgSb.append(I18nUtil.getString("jobconf_trigger_type")).append(":").append(triggerType.getTitle());
195-
triggerMsgSb.append("<br>").append(I18nUtil.getString("jobconf_trigger_admin_adress")).append(":").append(IpUtil.getIp());
195+
triggerMsgSb.append("<br>").append(I18nUtil.getString("jobconf_trigger_admin_adress")).append(":").append(IPTool.getIp());
196196
triggerMsgSb.append("<br>").append(I18nUtil.getString("jobconf_trigger_exe_regtype")).append(":")
197197
.append( (group.getAddressType() == 0)?I18nUtil.getString("jobgroup_field_addressType_0"):I18nUtil.getString("jobgroup_field_addressType_1") );
198198
triggerMsgSb.append("<br>").append(I18nUtil.getString("jobconf_trigger_exe_regaddress")).append(":").append(group.getRegistryList());

xxl-job-core/src/main/java/com/xxl/job/core/executor/XxlJobExecutor.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
import com.xxl.job.core.thread.JobLogFileCleanThread;
1111
import com.xxl.job.core.thread.JobThread;
1212
import com.xxl.job.core.thread.TriggerCallbackThread;
13-
import com.xxl.job.core.util.IpUtil;
14-
import com.xxl.job.core.util.NetUtil;
13+
import com.xxl.tool.core.StringTool;
14+
import com.xxl.tool.http.IPTool;
1515
import org.slf4j.Logger;
1616
import org.slf4j.LoggerFactory;
1717

@@ -147,12 +147,13 @@ public static List<AdminBiz> getAdminBizList(){
147147
private void initEmbedServer(String address, String ip, int port, String appname, String accessToken) throws Exception {
148148

149149
// fill ip port
150-
port = port>0?port: NetUtil.findAvailablePort(9999);
151-
ip = (ip!=null&&ip.trim().length()>0)?ip: IpUtil.getIp();
150+
port = port>0?port: IPTool.getAvailablePort(9999);
151+
ip = StringTool.isNotBlank(ip) ? ip : IPTool.getIp();
152152

153153
// generate address
154-
if (address==null || address.trim().length()==0) {
155-
String ip_port_address = IpUtil.getIpPort(ip, port); // registry-address:default use address to registry , otherwise use ip:port if address is null
154+
if (StringTool.isBlank(address)) {
155+
// registry-address:default use address to registry , otherwise use ip:port if address is null
156+
String ip_port_address = IPTool.toAddressString(IPTool.toAddress(ip, port));
156157
address = "http://{ip_port}/".replace("{ip_port}", ip_port_address);
157158
}
158159

xxl-job-core/src/main/java/com/xxl/job/core/util/IpUtil.java

Lines changed: 0 additions & 206 deletions
This file was deleted.

xxl-job-core/src/main/java/com/xxl/job/core/util/NetUtil.java

Lines changed: 0 additions & 70 deletions
This file was deleted.

0 commit comments

Comments
 (0)