Skip to content

Commit d8386b0

Browse files
hubertlu-twxwu-intel
authored andcommitted
[AMD] switch to custom allreduce regardless of MSCCL setting on ROCm (sgl-project#6097)
1 parent 967c369 commit d8386b0

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

python/sglang/srt/distributed/device_communicators/custom_all_reduce.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,6 @@ def __init__(
296296
self.meta, self.rank_data, handles, offsets, rank, self.full_nvlink
297297
)
298298
self.register_buffer(self.buffer)
299-
self.MSCCL = os.getenv("RCCL_MSCCL_ENABLE", "1") == "1"
300299

301300
self.disabled = False
302301

@@ -430,13 +429,7 @@ def should_custom_ar(self, inp: torch.Tensor):
430429

431430
if _is_hip:
432431
if self.full_nvlink:
433-
if self.world_size == 8:
434-
if self.MSCCL:
435-
return False
436-
else:
437-
return inp_size < self.max_size
438-
else:
439-
return inp_size < self.max_size
432+
return inp_size < self.max_size
440433
return False
441434

442435
return False

0 commit comments

Comments
 (0)