bug: fix relative url for refs

fix #88

Author: yanick

src/components/Instance/StringRestraints/index.svelte

@@ -30,7 +30,6 @@
 
   const tippy = tippy_orig || noop;
 
-
   import Range from "../Types/Range.svelte";
 
   import formats from "../Types/String/formats";

src/components/Instance/index.svelte

@@ -44,7 +44,7 @@
   {#if ref}
     <div>extends</div>
     <div>
-      <a href={'#' + relative_ref(ref)}>{ref}</a>
+      <a href={relative_ref(ref)}>{ref}</a>
 
       {#if is_expanded_ref}
         <input on:click={remove_ref} type="button" value="unexpand" />
@@ -157,6 +157,9 @@
   $: if (!id) id = href || "";
   $: if (id && !id.includes("#")) id = id + "#";
 
+  $: if (href && !href.includes("#")) {
+    href = href + "#";
+  }
   const fetch_ref = async () => {
     loading_ref = true;
 
@@ -181,10 +184,11 @@
 
   function relative_ref(ref) {
     if (ref.startsWith("#")) {
-      return id.replace(/#.*/, "") + ref;
+      console.log({ ref, id });
+      return "#" + id.replace(/#.*/, "") + ref;
     }
 
-    return ref;
+    return "#" + ref;
   }
 </script>
 

src/components/Instance/relative-url.test.js

@@ -0,0 +1,24 @@
+const tap = require("../../tests/svelte_loader");
+import { render } from "@testing-library/svelte";
+
+const Instance = require("./index.svelte");
+
+const definition = {
+  $id: "http://json-schema.org/draft-07/schema#",
+  type: "object",
+  properties: {
+    allOf: { $ref: "#/definitions/schemaArray" },
+  },
+};
+
+const { container } = render(Instance, { definition, href: definition.$id });
+
+const links = Array.from(container.querySelectorAll("a")).map((a) =>
+  a.getAttribute("href")
+);
+
+tap.equal(
+  links[0],
+  "#http://json-schema.org/draft-07/schema#/definitions/schemaArray",
+  "relative definition link is properly resolved"
+);