Allow LHS in destructuring-assignment #1825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Jun 14, 2018
| } | ||
| };`, | ||
| options: ['always'], | ||
| parser: 'babel-eslint' |
Member
There was a problem hiding this comment.
this test case doesn't require babel-eslint, let's remove this line
calebeby
referenced
this pull request
in Pigmice2733/scouting-frontend
Jun 30, 2018
This Pull Request updates dependency [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) from `v7.9.1` to `v7.10.0` <details> <summary>Release Notes</summary> ### [`v7.10.0`](https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md#​7100---2018-06-24) [Compare Source](jsx-eslint/eslint-plugin-react@v7.9.1...v7.10.0) ##### Added * Allow eslint ^5 ([#​1843][] @​papandreou, @​ljharb) * [`no-unsafe`][] rule ([#​1831][], [#​1830][] @​sergei-startsev) * [`no-will-update-set-state`][]: Account for `UNSAFE_` methods ([#​1845][], [#​1844][] @​alexzherdev) ##### Fixed * [`no-typos`][]: Fix static propTypes handling ([#​1827][], [#​1677][] @​alexzherdev) * [`destructuring-assignment`][]: Allow LHS ([#​1825][], [#​1728][] @​alexzherdev) * [`no-unused-prop-types`][]: Fix crash when encountering mixed union and intersection flow types ([#​1806][] @​yannickcr) ##### Changed * Typo fixes in [`jsx-no-target-blank`][] ([#​1805][] @​ferhatelmas)) [#​1845]: `https://github.com/yannickcr/eslint-plugin-react/pull/1845` [#​1844]: `https://github.com/yannickcr/eslint-plugin-react/issues/1844` [#​1843]: `https://github.com/yannickcr/eslint-plugin-react/pull/1843` [#​1831]: `https://github.com/yannickcr/eslint-plugin-react/pull/1831` [#​1830]: `https://github.com/yannickcr/eslint-plugin-react/issues/1830` [#​1827]: `https://github.com/yannickcr/eslint-plugin-react/pull/1827` [#​1825]: `https://github.com/yannickcr/eslint-plugin-react/pull/1825` [#​1806]: `https://github.com/yannickcr/eslint-plugin-react/issues/1806` [#​1805]: `https://github.com/yannickcr/eslint-plugin-react/pull/1805` [#​1728]: `https://github.com/yannickcr/eslint-plugin-react/issues/1728` [#​1677]: `https://github.com/yannickcr/eslint-plugin-react/issues/1677` --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).
ghost
mentioned this pull request
ghost
mentioned this pull request
This was referenced Sep 22, 2018
Closed
ghost
mentioned this pull request
This was referenced Nov 4, 2018
This was referenced Nov 23, 2018
1 task
1 task
1 task
This was referenced Dec 21, 2018
This was referenced Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1728
Not sure if this needs to also check that assignment is in the constructor? Also, would the following do anything useful / should this be allowed?