[jsx-pascal-case] Components can with $ or _ #2395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2394. $ and _ are valid names for components that are neither upper nor lower case. This change ensures the pascal case rule doesn't apply to single letter components
ljharb
reviewed
Aug 29, 2019
lib/rules/jsx-pascal-case.js
Outdated
| @@ -13,7 +13,7 @@ const jsxUtil = require('../util/jsx'); | |||
| // Constants | |||
| // ------------------------------------------------------------------------------ | |||
|
|
|||
| const PASCAL_CASE_REGEX = /^([A-Z0-9]|[A-Z0-9]+[a-z0-9]+(?:[A-Z0-9]+[a-z0-9]*)*)$/; | |||
| const PASCAL_CASE_REGEX = /^([$_A-Z0-9]|[$_]?[A-Z0-9]+[a-z0-9]+(?:[A-Z0-9]+[a-z0-9]*)*)$/; | |||
There was a problem hiding this comment.
maybe instead of this - which could allow much more complex patterns - we just bail out if [...name].length === 1?
There was a problem hiding this comment.
That would certainly work for me. Do we still want to disallow a single lowercase letter as the name?
There was a problem hiding this comment.
since anything that starts lowercase isn't a custom component, it's an html component, i don't think this rule would warn on it?
There was a problem hiding this comment.
Ah cool, in which case I'll make that change. Thanks.
ljharb
approved these changes
Aug 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2394.
$ and _ are valid names for components that are neither upper nor lower
case. This change ensures the pascal case rule only applies to the rest
of the component name (if any).