[fix]jsx-curly-brace-presence: report unnecessary curly braces on multline child expressions
#2409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h children on next line
vedadeepta
changed the title
sort-comp: report unnecessary curly braces on multline child expressionsjsx-curly-brace-presence: report unnecessary curly braces on multline child expressions
vedadeepta
force-pushed
the
2201-jsx-curly-brace-presence-multiline
branch
from
1f1593b to
21d8470
Compare
ljharb
reviewed
Sep 12, 2019
ljharb
reviewed
Sep 12, 2019
…o-danger-with-children`: add `isWhiteSpaces` to `lib/util/jsx`
ljharb
force-pushed
the
2201-jsx-curly-brace-presence-multiline
branch
from
bf4bb8d to
489ced3
Compare
ljharb
approved these changes
Sep 13, 2019
taion
reviewed
Oct 1, 2019
|
|
||
| function hasAdjacentJsxExpressionContainers(node, children) { | ||
| const childrenExcludingWhitespaceLiteral = children.filter(child => !isWhiteSpaceLiteral(child)); | ||
| const adjSiblings = getAdjacentSiblings(node, childrenExcludingWhitespaceLiteral); |
There was a problem hiding this comment.
I don't think this check is quite right. We now get stuff like:
<div>
- Confirm{' '}
+ Confirm
<button type="button" onClick={this.onClickYes}>But this is not the same markup and it's not desirable here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of change:
Checks for more than one non-whitespace literal children of
JsxElementinstead of directly checking forchidlren.length !== 1.