chore(nm): use for loop in buildTree fn (#4200)

* chore(nm): use for loop in buildTree fn

* chore: yarn version check --interactive

Author: trivikr

.yarn/versions/89ab2ac5.yml

@@ -0,0 +1,6 @@
+releases:
+  "@yarnpkg/nm": patch
+
+declined:
+  - "@yarnpkg/plugin-nm"
+  - "@yarnpkg/pnpify"

packages/yarnpkg-nm/sources/buildNodeModulesTree.ts

@@ -565,8 +565,7 @@ const populateNodeModulesTree = (pnp: PnpApi, hoistedTree: HoisterResult, option
         const segments = nodeModulesLocation.split(`/`);
         const nodeModulesIdx = segments.indexOf(NODE_MODULES);
 
-        let segCount = segments.length - 1;
-        while (nodeModulesIdx >= 0 && segCount > nodeModulesIdx) {
+        for (let segCount = segments.length - 1; nodeModulesIdx >= 0 && segCount > nodeModulesIdx; segCount--) {
           const dirPath = npath.toPortablePath(segments.slice(0, segCount).join(ppath.sep));
           const targetDir = toFilename(segments[segCount]);
 
@@ -580,8 +579,6 @@ const populateNodeModulesTree = (pnp: PnpApi, hoistedTree: HoisterResult, option
               subdirs.dirList.add(targetDir);
             }
           }
-
-          segCount--;
         }
       }