Removes the protocol when it matches the default one (#6917)

## What's the problem this PR addresses?

Yarn normalizes all ranges to prefix them by a unique registry string
(ie `npm:^2.0.0`) but other package managers don't understand those
explicit ranges (they expect `^2.0.0`).

Fixes #6913 

## How did you fix it?

Removes the protocol from the output before storing it in the
package.json when operating on `catalog:` replacements. This follows the
same logic as in `yarn add`.

## Checklist

<!--- Don't worry if you miss something, chores are automatically
tested. -->
<!--- This checklist exists to help you remember doing the chores when
you submit a PR. -->
<!--- Put an `x` in all the boxes that apply. -->
- [x] I have read the [Contributing
Guide](https://yarnpkg.com/advanced/contributing).

<!-- See
https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released
for more details. -->
<!-- Check with `yarn version check` and fix with `yarn version check
-i` -->
- [x] I have set the packages that need to be released for my changes to
be effective.

<!-- The "Testing chores" workflow validates that your PR follows our
guidelines. -->
<!-- If it doesn't pass, click on it to see details as to what your PR
might be missing. -->
- [x] I will check that all automated PR checks pass before the PR gets
reviewed.

Author: arcanis

.yarn/versions/b206e309.yml

@@ -0,0 +1,24 @@
+releases:
+  "@yarnpkg/cli": patch
+  "@yarnpkg/plugin-catalog": patch
+
+declined:
+  - "@yarnpkg/plugin-compat"
+  - "@yarnpkg/plugin-constraints"
+  - "@yarnpkg/plugin-dlx"
+  - "@yarnpkg/plugin-essentials"
+  - "@yarnpkg/plugin-init"
+  - "@yarnpkg/plugin-interactive-tools"
+  - "@yarnpkg/plugin-nm"
+  - "@yarnpkg/plugin-npm-cli"
+  - "@yarnpkg/plugin-pack"
+  - "@yarnpkg/plugin-patch"
+  - "@yarnpkg/plugin-pnp"
+  - "@yarnpkg/plugin-pnpm"
+  - "@yarnpkg/plugin-stage"
+  - "@yarnpkg/plugin-typescript"
+  - "@yarnpkg/plugin-version"
+  - "@yarnpkg/plugin-workspace-tools"
+  - "@yarnpkg/builder"
+  - "@yarnpkg/core"
+  - "@yarnpkg/doctor"

packages/acceptance-tests/pkg-tests-specs/sources/features/catalogs.test.ts

@@ -181,8 +181,8 @@ describe(`Features`, () => {
 
           const packedManifest = await xfs.readJsonPromise(`${path}/package/package.json` as PortablePath);
 
-          expect(packedManifest.dependencies[`no-deps`]).toBe(`npm:^2.0.0`);
-          expect(packedManifest.devDependencies[`one-fixed-dep`]).toBe(`npm:~1.0.0`);
+          expect(packedManifest.dependencies[`no-deps`]).toBe(`^2.0.0`);
+          expect(packedManifest.devDependencies[`one-fixed-dep`]).toBe(`~1.0.0`);
         },
       ),
     );

packages/plugin-catalog/sources/index.ts

@@ -85,8 +85,12 @@ const plugin: Plugin<CoreHooks & PackHooks> = {
           // Resolve the catalog reference to get the actual version range
           const resolvedDescriptor = resolveDescriptorFromCatalog(project, descriptor, resolver, resolveOptions);
 
+          let {protocol, source, params, selector} = structUtils.parseRange(structUtils.convertToManifestRange(resolvedDescriptor.range));
+          if (protocol === workspace.project.configuration.get(`defaultProtocol`))
+            protocol = null;
+
           // Replace the catalog reference with the resolved range
-          dependencies[identStr] = resolvedDescriptor.range;
+          dependencies[identStr] = structUtils.makeRange({protocol, source, params, selector});
         }
       }
     },

packages/plugin-catalog/sources/utils.ts

@@ -46,7 +46,6 @@ export const resolveDescriptorFromCatalog = (project: Project, dependency: Descr
   if (!resolvedRange)
     throw new ReportError(MessageName.RESOLUTION_FAILED, `${structUtils.prettyDescriptor(project.configuration, dependency)}: entry not found in ${getCatalogErrorDisplayName(catalogName)}`);
 
-
   // The range resolved from the catalog may need to be normalized (.i.e. ^2.4.0 -> npm:^2.4.0)
   // This process typically happens before the reduceDependency hook, but we need to do it here since
   // when it is first called the dependency range still refers to the catalog