fix(storage): clarify legacy replication status

Author: kkdras

src/components/VDiskStatus/i18n/en.json

@@ -16,6 +16,7 @@
   "value_waiting-for-token": "Waiting for token",
   "value_phantoms-only": "Phantoms only",
   "label_not-replicated": "Not replicated",
+  "value_no-detailed-status": "No detailed status",
   "context_state-ok": "The VDisk is operating normally",
   "context_state-initial": "The VDisk is starting",
   "context_state-sync-guid-recovery": "The VDisk is synchronizing with other VDisks of the group",

src/components/VDiskStatus/statuses.test.ts

@@ -1,3 +1,5 @@
+import {ArrowsRotateLeft, ArrowsRotateLeftSlash} from '@gravity-ui/icons';
+
 import type {EVDiskDetailedReplicationStatus} from '../../types/api/vdisk';
 import {EVDiskState} from '../../types/api/vdisk';
 
@@ -31,8 +33,39 @@ describe('VDisk replication label', () => {
     });
 
     test('uses the boolean fallback only when the detailed status is absent', () => {
-        expect(getVDiskReplicationLabel({Replicated: false})?.value).toBe('Not replicated');
+        expect(getVDiskReplicationLabel({Replicated: false})).toMatchObject({
+            value: 'Not replicated',
+            theme: 'normal',
+            icon: ArrowsRotateLeftSlash,
+        });
         expect(getVDiskReplicationLabel({Replicated: true})?.value).toBe('Replicated');
         expect(getVDiskReplicationLabel({})).toBeUndefined();
     });
+
+    test.each([
+        {ReplicationProgress: 0},
+        {ReplicationProgress: 0.77},
+        {ReplicationProgress: 1},
+        {ReplicationSecondsRemaining: 0},
+        {ReplicationSecondsRemaining: 125},
+    ])('shows No detailed status with available replication metrics %p', (metrics) => {
+        expect(getVDiskReplicationLabel({Replicated: false, ...metrics})).toMatchObject({
+            title: 'Replication',
+            value: 'No detailed status',
+            theme: 'info',
+            icon: ArrowsRotateLeft,
+        });
+    });
+
+    test.each([
+        {ReplicationProgress: -0.1},
+        {ReplicationProgress: 1.1},
+        {ReplicationProgress: NaN},
+        {ReplicationSecondsRemaining: -1},
+        {ReplicationSecondsRemaining: Infinity},
+    ])('keeps Not replicated when replication metrics are invalid %p', (metrics) => {
+        expect(getVDiskReplicationLabel({Replicated: false, ...metrics})?.value).toBe(
+            'Not replicated',
+        );
+    });
 });

src/components/VDiskStatus/statuses.ts

@@ -16,6 +16,7 @@ import {
 } from '../../utils/disks/constants';
 import {calculateStateIcon} from '../../utils/disks/iconCalculators';
 import type {PreparedVDisk} from '../../utils/disks/types';
+import {parseOptionalNonNegativeNumber} from '../../utils/utils';
 import type {DiskStatusLabelData} from '../DiskStatus/DiskStatus';
 
 import {vDiskStatusKeyset as i18n} from './i18n';
@@ -105,6 +106,17 @@ export function getVDiskReplicationLabel(data: PreparedVDisk): DiskStatusLabelDa
                 return replicatedLabel();
             }
             if (data.Replicated === false) {
+                const progress = parseOptionalNonNegativeNumber(data.ReplicationProgress);
+                const seconds = parseOptionalNonNegativeNumber(data.ReplicationSecondsRemaining);
+                if ((progress !== undefined && progress <= 1) || seconds !== undefined) {
+                    return {
+                        title: i18n('label_replication'),
+                        value: i18n('value_no-detailed-status'),
+                        theme: 'info',
+                        icon: ArrowsRotateLeft,
+                        tooltip: i18n('context_not-replicated'),
+                    };
+                }
                 return {
                     value: i18n('label_not-replicated'),
                     theme: 'normal',