fix: tests

Author: astandrik

tests/suites/tenant/TenantPage.ts

@@ -13,12 +13,34 @@ export enum NavigationTabs {
 export class TenantPage extends PageModel {
     private navigation: Locator;
     private radioGroup: Locator;
+    private diagnosticsContainer: Locator;
+    private emptyState: Locator;
+    private emptyStateTitle: Locator;
 
     constructor(page: Page) {
         super(page, tenantPage);
 
         this.navigation = page.locator('.ydb-tenant-navigation');
         this.radioGroup = this.navigation.locator('.g-radio-button');
+        this.diagnosticsContainer = page.locator('.kv-tenant-diagnostics');
+        this.emptyState = page.locator('.empty-state');
+        this.emptyStateTitle = this.emptyState.locator('.empty-state__title');
+    }
+
+    async waitForDiagnosticsToLoad() {
+        await this.diagnosticsContainer.waitFor({state: 'visible', timeout: VISIBILITY_TIMEOUT});
+    }
+
+    async isDiagnosticsVisible() {
+        return this.diagnosticsContainer.waitFor({state: 'visible', timeout: VISIBILITY_TIMEOUT});
+    }
+
+    async isEmptyStateVisible() {
+        return this.emptyState.waitFor({state: 'visible', timeout: VISIBILITY_TIMEOUT});
+    }
+
+    async getEmptyStateTitle(): Promise<string> {
+        return this.emptyStateTitle.innerText();
     }
 
     async selectNavigationTab(tabName: NavigationTabs) {

tests/suites/tenant/initialLoad.test.ts

@@ -14,10 +14,9 @@ test.describe('Tenant initial load', () => {
     test('Tenant diagnostics page is visible', async ({page}) => {
         const tenantPage = new TenantPage(page);
         await tenantPage.goto(pageQueryParams);
+        await tenantPage.waitForDiagnosticsToLoad();
 
-        await page.waitForTimeout(2000);
-
-        await expect(page.locator('.kv-tenant-diagnostics')).toBeVisible();
+        await expect(await tenantPage.isDiagnosticsVisible()).toBeTruthy();
     });
 
     test('Tenant diagnostics page is visible when describe returns no data', async ({page}) => {
@@ -27,8 +26,9 @@ test.describe('Tenant initial load', () => {
 
         const tenantPage = new TenantPage(page);
         await tenantPage.goto(pageQueryParams);
+        await tenantPage.waitForDiagnosticsToLoad();
 
-        await expect(page.locator('.kv-tenant-diagnostics')).toBeVisible();
+        await expect(await tenantPage.isDiagnosticsVisible()).toBeTruthy();
     });
 
     test('Tenant page shows error message when describe returns 401', async ({page}) => {
@@ -39,10 +39,8 @@ test.describe('Tenant initial load', () => {
         const tenantPage = new TenantPage(page);
         await tenantPage.goto(pageQueryParams);
 
-        await page.waitForTimeout(2000);
-
-        await expect(page.locator('.empty-state')).toBeVisible();
-        await expect(page.locator('.empty-state__title')).toHaveText('Access denied');
+        await expect(await tenantPage.isEmptyStateVisible()).toBeTruthy();
+        await expect(await tenantPage.getEmptyStateTitle()).toBe('Access denied');
     });
 
     test('Tenant page shows error message when describe returns 403', async ({page}) => {
@@ -53,7 +51,7 @@ test.describe('Tenant initial load', () => {
         const tenantPage = new TenantPage(page);
         await tenantPage.goto(pageQueryParams);
 
-        await expect(page.locator('.empty-state')).toBeVisible();
-        await expect(page.locator('.empty-state__title')).toHaveText('Access denied');
+        await expect(await tenantPage.isEmptyStateVisible()).toBeTruthy();
+        await expect(await tenantPage.getEmptyStateTitle()).toBe('Access denied');
     });
 });