feat(Nodes): add columns setup #1320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raubzeug
requested changes
Sep 20, 2024
| import type {GetNodesColumnsProps} from './types'; | ||
|
|
||
| export function useNodesColumns(params: GetNodesColumnsProps) { | ||
| return React.useMemo(() => { |
There was a problem hiding this comment.
It seems this wrapper is redundant. We do may use getNodesColumns(params) straightforward, don't we?
There was a problem hiding this comment.
Removed useNodesColumns hook, but left useMemo - its result is used in dependencies in hooks inside useSelectedColumn
Raubzeug
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1319
Stand: https://nda.ya.ru/t/0fhk33st78MARt
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Bundle Size: 🔺
Current: 78.99 MB | Main: 78.98 MB
Diff: +0.01 MB (0.02%)
ℹ️ CI Information