feat: dim vdisks on the node page that are not on the selected node #1369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
requested changes
Sep 27, 2024
| @@ -19,7 +21,7 @@ const b = cn('pdisk-storage-popup'); | |||
|
|
|||
| const errorColors = [EFlag.Orange, EFlag.Red, EFlag.Yellow]; | |||
|
|
|||
| export const preparePDiskData = (data: PreparedPDisk, nodes?: NodesMap) => { | |||
| export const preparePDiskData = (data: PreparedPDisk, nodeName?: string) => { | |||
There was a problem hiding this comment.
Please, use nodeHost name instead if nodeName. NodeName is another node field
There is an issue for displaying this property in tables: #1205
This comment relates to all entities in PR
Comment on lines
+31
to
+39
| {vDisks?.map((vDisk) => ( | ||
| <VDiskItem | ||
| key={stringifyVdiskId(vDisk.VDiskId)} | ||
| vDisk={vDisk} | ||
| inactive={!isVdiskActive(vDisk, viewContext)} | ||
| highlightedVDisk={highlightedVDisk} | ||
| setHighlightedVDisk={setHighlightedVDisk} | ||
| /> | ||
| ))} |
There was a problem hiding this comment.
We are both currently working on storage. Please, don't make such changes, if you don't really need them, so there will be less conflict to resolve
astandrik
force-pushed
the
astandrik.dim-vdisks-on-the-node-page-1361
branch
from
2f52573 to
b437c1c
Compare
|
@artemmufazalov |
artemmufazalov
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1361
Stand
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Bundle Size: ✅
Current: 79.13 MB | Main: 79.13 MB
Diff: +0.00 MB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information