feat: add developer ui links to disks popups #1512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
commented
Oct 22, 2024
| @@ -88,18 +91,18 @@ export const HoverPopup = ({ | |||
|
|
|||
| return ( | |||
| <React.Fragment> | |||
| <div ref={anchor} onMouseEnter={onMouseEnter} onMouseLeave={onMouseLeave}> | |||
| <span ref={anchor} onMouseEnter={onMouseEnter} onMouseLeave={onMouseLeave}> | |||
There was a problem hiding this comment.
div without additional styling doesn't work well for PDiskSpaceDistribution
artemmufazalov
commented
Oct 22, 2024
| }); | ||
|
|
||
| pdiskData.push({ | ||
| label: 'Links', |
There was a problem hiding this comment.
There is no i18n for this files, I don't want mix this chores with this feature (since it creates big diffs)
artemmufazalov
commented
Oct 22, 2024
| const preparedVDisks = WhiteboardVDisksData.map(prepareVDiskData).sort( | ||
| (disk1, disk2) => Number(disk2.VDiskSlotId) - Number(disk1.VDiskSlotId), | ||
| ); | ||
| const preparedVDisks = WhiteboardVDisksData.map((disk) => prepareVDiskData({...disk, NodeId})); |
There was a problem hiding this comment.
There is no NodeId in WhiteboardVDisksData, without it there is no VDisk Developer UI link in PDiskSpaceDistribution
Raubzeug
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1434
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Bundle Size: 🔺
Current: 79.03 MB | Main: 79.03 MB
Diff: +0.00 MB (0.01%)
ℹ️ CI Information