feat: implement simple and narrow vertical progress bar #1560
Conversation
| }, | ||
| align: DataTable.LEFT, | ||
| width: 85, | ||
| resizeMinWidth: 40, |
There was a problem hiding this comment.
It looks strange when resized. Let's do either with fixed bar width or non-resizable column.
| @@ -111,6 +118,57 @@ export function getMemoryColumn< | |||
| resizeMinWidth: 170, | |||
| }; | |||
| } | |||
|
|
|||
| export function getRAMColumn<T extends {MemoryUsed?: string; MemoryLimit?: string}>(): Column<T> { | |||
There was a problem hiding this comment.
There is no sorting for new columns if table is paginated.
Currently, for every column name is checked with isSortableNodesProperty, if name is in the list, the column is sortable and it's name is sent to backend as sort param.
I'm not sure what's to do in this case, since there are two columns with different ids, but they have the same sort fields (CPU and Memory).
Probably, you can use not column name, but add separate sortField property to every column object (in such case it's better to do it in a separate PR, since it's a lot of refactoring). Maybe there is a better and easier solution
There was a problem hiding this comment.
created dictionary for sort values
not sure if it's the best solution in the world, but as far as we decided to rename CPU to Pools looks like there are not so many choices left...
Stand Stand
Closes #1190
CI Results
Test Status: ✅ PASSED
📊 Full Report
Bundle Size: 🔺
Current: 79.20 MB | Main: 79.19 MB
Diff: +0.01 MB (0.01%)
ℹ️ CI Information