Merged
Conversation
artemmufazalov
force-pushed
the
1602-network-tab
branch
4 times, most recently
from
1497f98 to
34a230c
Compare
artemmufazalov
commented
Nov 15, 2024
| } | ||
| if (digits.length >= precision) { | ||
| return Math.round(Number(value)); | ||
| return Number(Number(value).toFixed(0)); |
Member
Author
There was a problem hiding this comment.
Math.round(0.5) = 1
Math.round(-0.5) = -0
Use toFixed to prevent it
artemmufazalov
force-pushed
the
1602-network-tab
branch
2 times, most recently
from
df19502 to
0142e07
Compare
artemmufazalov
force-pushed
the
1602-network-tab
branch
from
0142e07 to
14650fe
Compare
Raubzeug
requested changes
Nov 18, 2024
| export function prepareClockSkewValue(value: string | number) { | ||
| const valueMs = parseUsToMs(value, 1); | ||
| // Add + sign to positive values, do not add + to values that displayed as 0 | ||
| const sign = Number(valueMs) <= 0 ? '' : '+'; |
Contributor
There was a problem hiding this comment.
what if we use numeral formats for this? Like '+0,0'
Member
Author
There was a problem hiding this comment.
numeral adds + to 0 values, I don't like such display
numeral:
current solution:
Raubzeug
approved these changes
Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1602
Stand: https://nda.ya.ru/t/p6L2nqSM79fDT5
You need to turn on setting "Enable network table"
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Bundle Size: 🔺
Current: 66.10 MB | Main: 66.07 MB
Diff: +0.03 MB (0.05%)
ℹ️ CI Information