Skip to content

feat(Versions): use columns from Nodes table #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Nov 27, 2024

Closes #1072

I used equivalent columns from Nodes table.

  • Host + Endpoints -> nodes Host column (endpoints are displayed in popup)
  • Memory used + Memory limit -> RAM (memory details are displayed in popup)
  • Pools -> CPU (pools stats are displayed in popup)

Motivation: new columns have more data (e.g. node data in host popup), it is enough to update columns in one place to update it everywhere.

Although the displayed data remained the same, new version table look deserted, because new columns are much compact. However, we could easily add new columns with columns getters, if we want it.

Before:
Screenshot 2024-11-27 at 12 52 10

After:
Screenshot 2024-11-27 at 12 51 09

CI Results

Test Status: ✅ PASSED

📊 Full Report

Total Passed Failed Flaky Skipped
208 208 0 0 0

😟 No changes in tests. 😕

Bundle Size: 🔽

Current: 66.08 MB | Main: 66.09 MB
Diff: 7.96 KB (-0.01%)

✅ Bundle size decreased.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Comment on lines -24 to -25
@include freeze-nth-column(1);
@include freeze-nth-column(2, 80px);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated table is more compact, there is no need to freeze columns

@artemmufazalov artemmufazalov added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 9b3f779 Nov 27, 2024
9 checks passed
@artemmufazalov artemmufazalov deleted the 1072-versions-columns branch November 27, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the same columns for Nodes and Versions
2 participants