feat(Versions): use columns from Nodes table#1713
Merged
artemmufazalov merged 1 commit intomainfrom Nov 27, 2024
Merged
Conversation
4bb078f to
4798b36
Compare
artemmufazalov
commented
Nov 27, 2024
Comment on lines
-24
to
-25
| @include freeze-nth-column(1); | ||
| @include freeze-nth-column(2, 80px); |
Member
Author
There was a problem hiding this comment.
Updated table is more compact, there is no need to freeze columns
Raubzeug
approved these changes
Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1072
I used equivalent columns from Nodes table.
Motivation: new columns have more data (e.g. node data in host popup), it is enough to update columns in one place to update it everywhere.
Although the displayed data remained the same, new version table look deserted, because new columns are much compact. However, we could easily add new columns with columns getters, if we want it.
Before:

After:

CI Results
Test Status: ✅ PASSED
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: 🔽
Current: 66.08 MB | Main: 66.09 MB
Diff: 7.96 KB (-0.01%)
✅ Bundle size decreased.
ℹ️ CI Information