feat(TopQueries): add limit, sort on backend #1737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
commented
Dec 5, 2024
| @@ -127,7 +127,7 @@ | |||
| "@gravity-ui/tsconfig": "^1.0.0", | |||
| "@playwright/test": "^1.42.1", | |||
| "@testing-library/jest-dom": "^6.4.6", | |||
| "@testing-library/react": "^14.2.2", | |||
| "@testing-library/react": "^16.0.1", | |||
There was a problem hiding this comment.
Without it there is a warning when using renderHook function
artemmufazalov
commented
Dec 5, 2024
| }, | ||
| {pollingInterval: autoRefreshInterval}, | ||
| ); | ||
|
|
||
| const loading = isFetching && currentData === undefined; |
There was a problem hiding this comment.
isLoading query param isn't false when data initially loaded, but filters change. So when we change sort order and load new data, there is no-data message instead of loader. isFetching && currentData === undefined; prevents it
artemmufazalov
force-pushed
the
1700-top-queries-limit
branch
from
1428454 to
42f35bb
Compare
There was a problem hiding this comment.
Copilot reviewed 14 out of 29 changed files in this pull request and generated no suggestions.
Files not reviewed (15)
- package.json: Language not supported
- src/containers/Tenant/Diagnostics/TopQueries/columns/i18n/en.json: Language not supported
- src/containers/Tenant/Diagnostics/TopQueries/i18n/en.json: Language not supported
- src/containers/Tenant/Diagnostics/TopShards/columns/i18n/en.json: Language not supported
- src/containers/Tenant/Diagnostics/TopShards/columns/columns.tsx: Evaluated as low risk
- src/containers/Tenant/Diagnostics/TopShards/columns/i18n/index.ts: Evaluated as low risk
- src/containers/Storage/StorageNodes/StorageNodesTable.tsx: Evaluated as low risk
- src/containers/Tenant/Diagnostics/TenantOverview/TenantCpu/TopQueries.tsx: Evaluated as low risk
- src/containers/Storage/Storage.tsx: Evaluated as low risk
- src/containers/Tenant/Diagnostics/TenantOverview/TenantCpu/TopShards.tsx: Evaluated as low risk
- src/containers/Tenant/Diagnostics/TopShards/TopShards.tsx: Evaluated as low risk
- src/containers/Tenant/Diagnostics/TopQueries/TopQueriesData.tsx: Evaluated as low risk
- src/containers/Tenant/Diagnostics/TopQueries/RunningQueriesData.tsx: Evaluated as low risk
- src/containers/Storage/StorageGroups/StorageGroupsTable.tsx: Evaluated as low risk
- src/containers/Tenant/Diagnostics/TopQueries/columns/columns.tsx: Evaluated as low risk
astandrik
reviewed
Dec 6, 2024
| ...column, | ||
| sortable: isSortableTopQueriesProperty(column.name), | ||
| })); | ||
| const columns = getTopQueriesColumns(); |
There was a problem hiding this comment.
Columns are recreated on every render - this could be memoized
astandrik
reviewed
Dec 6, 2024
| @@ -28,6 +31,32 @@ import {defaultSortNode, getDefaultSortGroup} from './utils'; | |||
|
|
|||
| import './Storage.scss'; | |||
|
|
|||
| export function useStorageSort< | |||
There was a problem hiding this comment.
Maybe move it to hooks folder? Not to expand component file with hooks. Large files with all-in-one have worse readability
astandrik
reviewed
Dec 6, 2024
| const [groupsSort, handleGroupsSort] = useTableSort(groupsSortParams, (params) => | ||
| setGroupSort(params as StorageSortParams), | ||
| ); | ||
| const [nodesSort, handleNodesSort] = useStorageSort(nodesSortParams, setNodeSort); |
There was a problem hiding this comment.
Maybe istead of nesting hooks we could do more straightforward:
function fromTableSort<T extends NodesSortParams | StorageSortParams>(
sort: SortOrder[] | undefined,
): T | undefined {
if (!sort?.[0]) {
return undefined;
}
return {
sortValue: sort[0].columnId,
sortOrder: sort[0].order,
} as T;
}
const [nodesSort, handleNodesSort] = useTableSort({
initialSortColumn: nodesSortParams.sortValue,
initialSortOrder: nodesSortParams.sortOrder,
multiple: false,
onSort: (sort) => setNodeSort(fromTableSort<NodesSortParams>(sort)),
});
const [groupsSort, handleGroupsSort] = useTableSort({
initialSortColumn: groupsSortParams.sortValue,
initialSortOrder: groupsSortParams.sortOrder,
multiple: false,
onSort: (sort) => setGroupSort(fromTableSort<StorageSortParams>(sort)),
});
There was a problem hiding this comment.
Current version works as before, I don't see the reason to make it beautiful, since you are deleting it anyway in #1693
astandrik
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1700
Stand: https://nda.ya.ru/t/eyQNOFQ17AB7E2
CI Results
Test Status: ✅ PASSED
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: 🔺
Current: 65.86 MB | Main: 65.85 MB
Diff: +0.01 MB (0.02%)
ℹ️ CI Information