fix: execution plan svg not saving in chrome#1744
Merged
Conversation
artemmufazalov
previously approved these changes
Dec 10, 2024
Raubzeug
previously approved these changes
Dec 10, 2024
| }) | ||
| .catch((err) => { | ||
| setError(JSON.stringify(err)); | ||
| const errorMessage = err.data?.message || err.message || JSON.stringify(err); |
Contributor
There was a problem hiding this comment.
Don't we want to move such a logic into a helper (we have similar logic in ResponseError and parseQueryError)?
Collaborator
Author
There was a problem hiding this comment.
moved to utils/errors
astandrik
dismissed stale reviews from Raubzeug and artemmufazalov
via
d2dbd72
Raubzeug
approved these changes
Dec 12, 2024
astandrik
deleted the
astandrik.move-storage-tables-to-paginated-1693
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1743
CI Results
Test Status: ✅ PASSED
📊 Full Report
Test Changes Summary ✨3 🗑️1
✨ New Tests (3)
🗑️ Deleted Tests (1)
Bundle Size: 🔺
Current: 65.88 MB | Main: 65.87 MB
Diff: +5.96 KB (0.01%)
ℹ️ CI Information