Skip to content

feat(autocomplete): suggest columns from subqueries #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 26, 2024
Merged

feat(autocomplete): suggest columns from subqueries #1788

merged 2 commits into from
Dec 26, 2024

Conversation

Raubzeug
Copy link
Contributor

@Raubzeug Raubzeug commented Dec 26, 2024 •
edited by github-actions bot
Loading

closes #898
closes #903

Stand

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
232 231 0 1 0

😟 No changes in tests. 😕

Bundle Size: 🔺

Current: 66.17 MB | Main: 66.16 MB
Diff: +8.91 KB (0.01%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@Raubzeug Raubzeug requested a review from astandrik December 26, 2024 07:31
@astandrik astandrik requested a review from Copilot December 26, 2024 08:38
Copilot
Copilot AI reviewed Dec 26, 2024
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • package.json: Language not supported

src/utils/monaco/yql/generateSuggestions.ts Outdated
let columnsFromVariable: TAutocompleteEntity[] = [];
if (variableSources.length) {
variableSources.forEach((source) => {
columnsFromVariable =
Copy link
Preview

Copilot AI Dec 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reassigning columnsFromVariable inside the loop could lead to unexpected results. It should accumulate results instead. Change to columnsFromVariable.push(...).

Copilot uses AI. Check for mistakes.

@astandrik astandrik requested a review from Copilot December 26, 2024 08:47
Copilot
Copilot AI reviewed Dec 26, 2024
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • package.json: Language not supported

@Raubzeug Raubzeug added this pull request to the merge queue Dec 26, 2024
Merged via the queue into main with commit 1095d96 Dec 26, 2024
7 checks passed
@Raubzeug Raubzeug deleted the autocomplete branch December 26, 2024 09:55
@ydb-platform-bot ydb-platform-bot mentioned this pull request Dec 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@astandrik astandrik astandrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Raubzeug @astandrik