feat(QueryEditor): add error highlighting #1833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astandrik
reviewed
Jan 17, 2025
astandrik
reviewed
Jan 17, 2025
astandrik
reviewed
Jan 17, 2025
astandrik
reviewed
Jan 17, 2025
src/utils/monaco/highlightErrors.ts
Outdated
| disableErrorsHighlighting(); | ||
|
|
||
| clearTimeout(errorsHighlightingTimeoutId); | ||
| errorsHighlightingTimeoutId = setTimeout(() => highlightErrors(), 500); |
There was a problem hiding this comment.
will it highlight incorrect errors if I change editor within 500 ms?
Raubzeug
force-pushed
the
highlight-errors-1796
branch
from
2caf2d8 to
3f22c2f
Compare
astandrik
reviewed
Jan 17, 2025
astandrik
reviewed
Jan 20, 2025
src/utils/monaco/highlightErrors.ts
Outdated
|
|
||
| const owner = 'ydb'; | ||
|
|
||
| export function useUpdateErrorsHighlighting() { |
There was a problem hiding this comment.
lets try debounce approach - if its appliable here
Raubzeug
force-pushed
the
highlight-errors-1796
branch
from
33c068b to
525357c
Compare
astandrik
reviewed
Jan 20, 2025
|
|
||
| const owner = 'ydb'; | ||
|
|
||
| const debouncedHighlightErrors = debounce(highlightErrors, 500); |
There was a problem hiding this comment.
I think we should cancel it on useEffect return
astandrik
previously approved these changes
Jan 20, 2025
astandrik
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1796
Stand
CI Results
Test Status: ❌ FAILED
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: 🔺
Current: 80.05 MB | Main: 79.96 MB
Diff: +0.09 MB (0.11%)
ℹ️ CI Information