Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the export operation kind identifier from "export" to "export/s3" for better specificity and consistency.
- Changed the operation kind in the constants file along with its localization key.
- Updated the OperationKind type in the API types file.
- Modified the zod schema in the query parameters hook to validate the new kind.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/containers/Operations/constants.ts | Updated operation kind value and localization key for export operations. |
| src/types/api/operations.ts | Revised OperationKind union to replace "export" with "export/s3". |
| src/containers/Operations/useOperationsQueryParams.ts | Adjusted zod enum values to validate "export/s3". |
Files not reviewed (1)
- src/containers/Operations/i18n/en.json: Language not supported
artemmufazalov
previously approved these changes
Mar 20, 2025
artemmufazalov
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2029
CI Results
Test Status: ✅ PASSED
📊 Full Report
Test Changes Summary ⏭️1
⏭️ Skipped Tests (1)
Bundle Size: ✅
Current: 83.22 MB | Main: 83.22 MB
Diff: 1.47 KB (-0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information