Skip to content

fix: use blue color only for not replicated vdisks #2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Apr 4, 2025

Closes #2081

CI Results

Test Status: βœ… PASSED

πŸ“Š Full Report

Total Passed Failed Flaky Skipped
298 298 0 0 0

😟 No changes in tests. πŸ˜•

Bundle Size: βœ…

Current: 83.27 MB | Main: 83.27 MB
Diff: +0.24 KB (0.00%)

βœ… Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • πŸ“Š indicates links to detailed reports.
  • πŸ”Ί indicates increase, πŸ”½ decrease, and βœ… no change in bundle size.

@@ -52,5 +52,10 @@ function getColorSeverity(color?: EFlag) {
return NOT_AVAILABLE_SEVERITY;
}

// Blue is reserved for not replicated VDisks
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getColorSeverity is used to convert DiskSpace and FrontQueues flags to severity

@artemmufazalov artemmufazalov marked this pull request as ready for review April 4, 2025 13:56
Copy link
Contributor

@Raubzeug Raubzeug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add a test for this case

@artemmufazalov artemmufazalov requested a review from Raubzeug April 7, 2025 10:40
@artemmufazalov artemmufazalov added this pull request to the merge queue Apr 7, 2025
Merged via the queue into main with commit 2e6051b Apr 7, 2025
7 checks passed
@artemmufazalov artemmufazalov deleted the 2081-vdisk-blue-states branch April 7, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Green for Blue vdisk DiskSpace and FrontQueues flags
2 participants