Skip to content

feat(Clusters): correct links with relative path in balancer #2121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Apr 8, 2025

Closes #2105

How it works without this fix: https://nda.ya.ru/t/1lxnjz4a7DSgCM

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
312 311 0 1 0

😟 No changes in tests. 😕

Bundle Size: ✅

Current: 83.28 MB | Main: 83.28 MB
Diff: +1.61 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@artemmufazalov artemmufazalov requested a review from Copilot April 8, 2025 11:58
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/utils/parseBalancer.ts:65

  • [nitpick] When concatenating window.meta_backend with preparedBalancer on line 66, ensure that the meta_backend value does not include a trailing slash to avoid accidental double slashes. Consider normalizing the URL parts before concatenation.
if (window.meta_backend) {

@artemmufazalov artemmufazalov force-pushed the 2105-relative-balancer-value branch from 63cac19 to b6feda6 Compare April 8, 2025 12:00
@artemmufazalov artemmufazalov force-pushed the 2105-relative-balancer-value branch from b6feda6 to 4d52a6b Compare April 8, 2025 12:21
@artemmufazalov artemmufazalov marked this pull request as ready for review April 8, 2025 12:23
@artemmufazalov artemmufazalov requested a review from astandrik April 8, 2025 12:33
@artemmufazalov artemmufazalov changed the title feat: process relative path in balancer feat(Clusters): correct links with relative parh in balancer Apr 8, 2025
@artemmufazalov artemmufazalov changed the title feat(Clusters): correct links with relative parh in balancer feat(Clusters): correct links with relative path in balancer Apr 8, 2025
@artemmufazalov artemmufazalov requested a review from Raubzeug April 9, 2025 07:26
@artemmufazalov artemmufazalov added this pull request to the merge queue Apr 9, 2025
Merged via the queue into main with commit 4776c0c Apr 9, 2025
11 checks passed
@artemmufazalov artemmufazalov deleted the 2105-relative-balancer-value branch April 9, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Build]: enable UI to work with relative balancer value
2 participants