feat(Tenants): correct links with relative path in balancer#2125
Merged
artemmufazalov merged 1 commit intomainfrom Apr 10, 2025
Merged
feat(Tenants): correct links with relative path in balancer#2125artemmufazalov merged 1 commit intomainfrom
artemmufazalov merged 1 commit intomainfrom
Conversation
artemmufazalov
commented
Apr 9, 2025
| StorageAllocatedSize?: string; // Actual database size | ||
| /** uint64 */ | ||
| StorageMinAvailableSize?: string; | ||
| Nodes?: TSystemStateInfo[]; |
Member
Author
There was a problem hiding this comment.
Nodes and MonitoringEndpoint requires additional param in endpoint (nodes=true), we don't sent this param and thus never have these fields in response
astandrik
reviewed
Apr 10, 2025
astandrik
approved these changes
Apr 10, 2025
Collaborator
astandrik
left a comment
astandrik
left a comment
There was a problem hiding this comment.
I'm sure we discussed this pr more than enough in pm =)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2105
Changes:
How to check changes
Add following changes to
.envfile and run app withnpm run startYDB DEV VLA02andklg1-0561have paths relative to meta as balancer and these paths are also a little different. UI without this fix makes incorrect links to Tenant page and Developer UI.YDB RU PRESTABLEhas full balancer value, it works on current version and should work after fix.CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 83.29 MB | Main: 83.29 MB
Diff: +1.54 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information