fix: update autorefresh if more that autorefresh in inactive tab passed#2140
Merged
fix: update autorefresh if more that autorefresh in inactive tab passed#2140
Conversation
Raubzeug
requested changes
Apr 11, 2025
Contributor
Raubzeug
left a comment
Raubzeug
left a comment
There was a problem hiding this comment.
Lets use skipPollingIfUnfocused in global rtk config!
Raubzeug
reviewed
Apr 11, 2025
Contributor
There was a problem hiding this comment.
Copilot reviewed 38 out of 38 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/components/MetricChart/MetricChart.tsx:149
- [nitpick] The variable 'autorefresh' is used here instead of the common camelCase 'autoRefreshInterval' seen throughout the code. For consistency, consider renaming it.
{pollingInterval: autorefresh, skipPollingIfUnfocused: true}
Raubzeug
requested changes
Apr 12, 2025
Contributor
Raubzeug
left a comment
Raubzeug
left a comment
There was a problem hiding this comment.
discussed in pm, skipPollingIfUnfocused works weird, so let's stick to your previous implementation
astandrik
force-pushed
the
astandrik.2123-2
branch
from
26e174b to
c37dcba
Compare
Collaborator
Author
|
@Raubzeug fixed, redeployed stand |
Raubzeug
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2123
Stand
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 83.36 MB | Main: 83.36 MB
Diff: +1.43 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information