Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the column width calculation in the storage settings by ensuring the calculated physical disk width does not fall below a given minimum threshold.
- Update the calculation of calculatedPDiskWidth to use Math.max for enforcing a minimum width
- Adjust the disk container width calculation accordingly
Comments suppressed due to low confidence (1)
src/containers/Storage/utils/useStorageColumnsSettings.ts:26
- Consider adding test cases to cover the scenario where the computed width is below PDISK_MIN_WIDTH to ensure that the minimum width enforcement works as expected.
const calculatedPDiskWidth = Math.max(
Raubzeug
approved these changes
Apr 29, 2025
artemmufazalov
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stand
missed max instruction

CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 83.38 MB | Main: 83.38 MB
Diff: +0.10 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information