Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to fix slash inconsistencies in schema and breadcrumb handling.
- Introduces a helper function (prepareSchemaRootName) in ObjectTree.tsx to ensure the schema root name always starts with a slash.
- Removes the prepareTenantName function in breadcrumbs.tsx to stop stripping leading slashes from tenant names.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/containers/Tenant/ObjectSummary/ObjectTree.tsx | Adds prepareSchemaRootName to enforce a leading slash on root names. |
| src/containers/Header/breadcrumbs.tsx | Removes prepareTenantName and adjusts tenant name display in breadcrumbs. |
Comments suppressed due to low confidence (1)
src/containers/Header/breadcrumbs.tsx:65
- [nitpick] Removing the function that strips a leading slash changes the tenant breadcrumb display. Verify that preserving the leading slash in tenantName aligns with the intended UI design and maintains consistency across the application.
const text = tenantName ? tenantName : headerKeyset('breadcrumbs.tenant');
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the issue of inconsistent slashes in path strings across components. The key changes include:
- Introducing the prepareSchemaRootName helper function in ObjectTree.tsx to ensure path strings start with a slash.
- Updating the ObjectTree component to use the new helper function.
- Removing the prepareTenantName function in breadcrumbs.tsx to prevent unintended modification of tenantName slashes.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/containers/Tenant/ObjectSummary/ObjectTree.tsx | Added a helper function to prefix slashes to schema names and updated its usage when passing rootName to SchemaTree. |
| src/containers/Header/breadcrumbs.tsx | Removed the function that stripped leading slashes from tenant names, relying instead on the original tenantName. |
artemmufazalov
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2091
Stand
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 83.47 MB | Main: 83.47 MB
Diff: +0.17 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information