fix: paginatedTable - calculate visible range on resize#2248
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the paginated table’s visible range calculation on window resize by updating the scroll and resize handling logic and adding mock node generation support.
- Introduces a new node generator in nodes.ts to simulate storage nodes.
- Updates getNodes.ts to use the new generator when mock mode is enabled via URL parameters.
- Refactors useScrollBasedChunks.ts to replace lodash throttle with rafThrottle and improve resize handling.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/containers/Storage/StorageNodes/nodes.ts | Adds node generation utilities for simulating storage node data. |
| src/containers/Storage/StorageNodes/getNodes.ts | Integrates mock node generation using URL parameter flags. |
| src/components/PaginatedTable/useScrollBasedChunks.ts | Replaces lodash throttle with rafThrottle and updates resize events. |
Comments suppressed due to low confidence (1)
src/containers/Storage/StorageNodes/nodes.ts:25
- [nitpick] Consider renaming the callback parameter 'Name' to 'poolName' to improve clarity and avoid potential confusion with types or class names.
poolNames.slice(0, count).map((Name) => ({
artemmufazalov
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2245
Stand
🧠 Detailed Comparison of throttle and rafThrottle
1. Lodash’s
throttle(Current Implementation)🧩 Conceptual Overview:
100ms) to limit execution frequency✅ Pros:
cancel()method for cleanup❌ Cons:
2.
rafThrottle(Available inutils.tsx)🧩 Conceptual Overview:
requestAnimationFrameto sync with the browser’s rendering cycle✅ Pros:
❌ Cons:
cancelAnimationFramefor cleanup (a slightly different pattern)📊 Comparison Matrix
throttlerafThrottle✅ Recommendation
For
useScrollBasedChunks,rafThrottleis the better choice, because:CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 83.47 MB | Main: 83.47 MB
Diff: +0.30 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information