fix!: remove internal-specific solution#2261
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the internal-specific implementation of the getLogsLink function to promote a common-purpose solution.
- Removed the internal getLogsLink function and its associated tests.
- Updated AppWithClusters to no longer rely on a predefined getLogsLink default.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/utils/logs.ts | Removed internal-specific getLogsLink implementation. |
| src/utils/test/logs.test.ts | Removed tests related to the now-deleted getLogsLink. |
| src/containers/AppWithClusters/AppWithClusters.tsx | Removed default import and prop for getLogsLink. |
Raubzeug
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now that doesnt look as a library common-purpose solution at all...
better remove internal-specific implementation and just leave getLogsLink as an optional function passing to AppWithClusters getLogsLink as a function if logs source exists
major release as backward compatibility breaks here
#2260 (comment)
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 83.47 MB | Main: 83.47 MB
Diff: 2.17 KB (-0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information