Skip to content

feat(vDisk): allow evict vDisk by id#2267

Merged
ValeraS merged 2 commits intomainfrom
issue-2226
May 14, 2025
Merged

feat(vDisk): allow evict vDisk by id#2267
ValeraS merged 2 commits intomainfrom
issue-2226

Conversation

@ValeraS
Copy link
Copy Markdown
Collaborator

@ValeraS ValeraS commented May 8, 2025

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
318 317 0 1 0

😟 No changes in tests. 😕

Bundle Size: ✅

Current: 83.53 MB | Main: 83.53 MB
Diff: +2.06 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@ValeraS ValeraS requested a review from artemmufazalov May 8, 2025 09:33
@ValeraS ValeraS linked an issue May 8, 2025 that may be closed by this pull request
Comment thread src/components/VDisk/utils.ts Outdated
Comment on lines +16 to +18
undefined as unknown as string,
data.PDiskId as number,
data.NodeId as number,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can instead modify getVDiskPagePath function and pass params without type assertions

export function getVDiskPagePath(
    params:
        | {
              vDiskSlotId: string | number;
              pDiskId: string | number;
              nodeId: string | number;
          }
        | {pDiskId?: string | number; nodeId?: string | number; vDiskId: string | number},
    query: Query = {},
) {
    return createHref(routes.vDisk, undefined, {...query, ...params});
}

@ValeraS ValeraS added this pull request to the merge queue May 14, 2025
Merged via the queue into main with commit 410d4d4 May 14, 2025
5 checks passed
@ValeraS ValeraS deleted the issue-2226 branch May 14, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't evict on VDisk page when no info from Whiteboard

2 participants